Integrate Rust bindings as library #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need to add Rust lib building, but it requires adding a script that does the equivalent of what 'cargo-swift' does.
bisgardo
commented
Jan 24, 2024
rh-concordium
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Rust binding library
ConcordiumWalletCryptowhich implements the functions currently exposed in theConcordiumHdWalletin the JavaScript SDK. The functions are made available from the SDK viaConcordiumHdWalletas well. The unit tests have been ported from the other SDK also.The bindings are generated by UniFFI via
cargo-swift. That tool was mainly helpful for setting up the structure of the project, it probably isn't really required for actually building the lib. As it's ability to compile seems a little flaky and because we might want to build fewer variants for the purpose of CI, it seems reasonable that we'd replace this dependency with a simple script that does the same thing.Resolves https://concordium.atlassian.net/browse/CBW-1552.