Replace cargo-swift with equivalent script #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent is to have both targets of the package `./lib/crypto/ConcordiumWalletCrypto` generated using SPM build plugins. I suppose this amounts to reimplementing `build.sh` in Swift or just calling the script from Swift.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the framework with a shell script will (hopefully) make it clearer what's actually going on.
Going forward it will also give us more control over the exact procedure like for instance whether to build universal binaries or support arm64 only. For example it's only necessary to build a single target on the CI when running unit tests (for now we build for all platforms on the CI).
Last but not least it will allow us to remove a dependency that we don't actually need.