Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P8 update proposal #69

Merged
merged 6 commits into from
Jan 6, 2025
Merged

P8 update proposal #69

merged 6 commits into from
Jan 6, 2025

Conversation

td202
Copy link
Contributor

@td202 td202 commented Dec 3, 2024 •
edited
Loading

Purpose

Closes #67

Define the protocol version 8 update.

Changes

  • Add P8 description.
  • Add P8 commentary.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

drsk0
drsk0 approved these changes Dec 3, 2024
View reviewed changes
Copy link

@drsk0 drsk0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

updates/P8.txt Outdated Show resolved Hide resolved
chportma
chportma requested changes Dec 4, 2024
View reviewed changes
Copy link

@chportma chportma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few clarifications and changes needed.

commentary/P8-commentary.txt Outdated Show resolved Hide resolved
updates/P8.txt Outdated Show resolved Hide resolved
updates/P8.txt Outdated Show resolved Hide resolved
updates/P8.txt Outdated Show resolved Hide resolved
commentary/P8-commentary.txt Outdated Show resolved Hide resolved
updates/P8.txt Outdated Show resolved Hide resolved
@eb-concordium eb-concordium mentioned this pull request Dec 11, 2024
Merged
5 tasks
@td202 td202 requested a review from chportma January 3, 2025 16:34
chportma
chportma approved these changes Jan 4, 2025
View reviewed changes
Copy link

@chportma chportma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write-up! Thank you for all the changes.

@td202 td202 merged commit e78c5b1 into main Jan 6, 2025
2 checks passed
@td202 td202 deleted the p8-proposal branch January 6, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chportma chportma chportma approved these changes

@eb-concordium eb-concordium eb-concordium approved these changes

@drsk0 drsk0 drsk0 approved these changes

@tschudid tschudid Awaiting requested review from tschudid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protocol 8 Update Proposal
4 participants
@td202 @drsk0 @eb-concordium @chportma