This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Rename AcceptedTermsAndConditions types #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it's misleading to name the `AcceptedTermsAndConditionsState` "state" as it's really just a value that can be passed around, not necessarily in the context of state. It was renamed in a previous PR to give the new Hive entity its name instead. I think it's important to not refer to entity objects directly from the widgets, and therefore useful to explicitly suffix entity types with `Entity` to make it clear if it happens. As such, the changes in this PR is just the renamings - `AcceptedTermsAndConditionsState` -> `AcceptedTermsAndConditions` - `AcceptedTermsAndConditions` -> `AcceptedTermsAndConditionsEntity` Also `acceptNow` was renamed to `acceptedNow` to avoid indicating that it has a side effect.
ghost
approved these changes
Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's misleading to name the
AcceptedTermsAndConditionsState"state" as it's really just a value that can be passed around, not necessarily in the context of state. It was renamed in a previous PR to give the new Hive entity its name instead. I think it's important to not refer to entity objects directly from the widgets, and therefore useful to explicitly suffix entity types withEntityto make it clear if it happens.As such, the changes in this PR is just the renamings
AcceptedTermsAndConditionsState->AcceptedTermsAndConditionsAcceptedTermsAndConditions->AcceptedTermsAndConditionsEntityAlso
acceptNowwas renamed toacceptedNowto avoid indicating that it has a side effect.