Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed and reorganised smart contract articles #1168

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

dragosgd
Copy link
Contributor

@dragosgd dragosgd commented Dec 5, 2024

Purpose

Review and update Docs Smart Contracts section. The scope of this PR is to give clear names to articles.
On top of this, the 2 Best practices articles were reorganised under 1 section for consistency. An introductory article was written for this.
Also, an obviously unnecessary warning was removed.

Changes

  • rename for shorter, more concise, names
  • reorganise Best Practices
  • write intro article for Best Practices
  • remove unnecessary warning

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

@dragosgd dragosgd requested review from it09 and TinaKT December 5, 2024 14:46
@dragosgd dragosgd self-assigned this Dec 5, 2024
Copy link
Contributor

@TinaKT TinaKT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good improvements, shorter headings works much better.

Copy link
Contributor

@it09 it09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start!

Copy link
Contributor

@it09 it09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great progress

@dragosgd dragosgd merged commit cbf6bbc into main Dec 6, 2024
2 checks passed
@dragosgd dragosgd deleted the DOC301-RenameSmartContracts branch December 6, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants