Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full details of the WalletConnect transaction to sign #10

Merged
merged 8 commits into from
Mar 26, 2024

Conversation

Radiokot
Copy link
Member

Purpose

Along with the recent changes this completes WAL2-45 (transaction screen doesn't contain information as in Concordium Wallets).

Changes

  • Add "Show details" button for WalletConnect contract update transaction signing requests, which shows the call parameters and max energy in a scrollable dialog

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Copy link

linear bot commented Mar 12, 2024

WAL2-45 CryptoX-Android-sign transaction screen doesn't contain information as in Concordium Wallets

To reproduce:

  1. Try to wrap CCDs on Testnet with both Concordium wallet and CryptoX wallet.
  2. Observe and compare screens when signing tx.

Expected:

Align signing pages (look at the screenshot and please neglect the red bubble on screenshot).

Sign_contract_page.png

@Radiokot Radiokot requested a review from orhoj March 12, 2024 13:28
@Radiokot Radiokot requested a review from orhoj March 13, 2024 16:22
@Radiokot Radiokot requested review from shjortConcordium and orhoj and removed request for orhoj March 26, 2024 10:50
@Radiokot Radiokot merged commit 60131a5 into main Mar 26, 2024
1 check passed
@Radiokot Radiokot deleted the fix/WAL2-45 branch March 26, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants