Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty transaction export #5

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Fix empty transaction export #5

merged 2 commits into from
Mar 5, 2024

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Mar 4, 2024

Purpose

Add graceful handling of the 204 NO_CONTENT code that ccdscan returns when trying to download transactions for an account without any.

Changes

  • Check for the status code when getting a response and handle accordingly. We now show a specific information message if there were no transactions for that account.
  • Fixed a bug where the UI would flash when using the "back" button in the top bar.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj orhoj requested a review from Radiokot March 4, 2024 12:26
@orhoj orhoj merged commit afc3354 into main Mar 5, 2024
1 check passed
@orhoj orhoj deleted the fix-empty-transaction-export branch March 5, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radiokot Radiokot Radiokot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @Radiokot