Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Center identity name when edit icon is visible #6

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Center identity name when edit icon is visible #6

merged 2 commits into from
Mar 5, 2024

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Mar 4, 2024

Purpose

Fix a UI issue where the identity name was off-center if the edit name icon was visible.

Changes

  • Center the identity name.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@orhoj orhoj requested a review from Radiokot March 4, 2024 13:11
Radiokot
Radiokot approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Radiokot Radiokot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and looks fine with long names as well 👌🏻

@orhoj orhoj merged commit 3f79fac into main Mar 5, 2024
1 check passed
@orhoj orhoj deleted the fix-off-center-identity-name branch March 5, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radiokot Radiokot Radiokot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @Radiokot