Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config - Don't populate empty defaults #39

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Config - Don't populate empty defaults #39

merged 1 commit into from
Apr 17, 2024

Conversation

lovromazgon
Copy link
Member

Description

I noticed a strange behavior in the generator connector because the SDK populated fields that had no defaults. Now defaults are only populated if the field actually has a default value.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner April 17, 2024 16:25
maha-hajja
maha-hajja approved these changes Apr 17, 2024
View reviewed changes
Copy link

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@lovromazgon lovromazgon merged commit a77201a into main Apr 17, 2024
5 checks passed
@lovromazgon lovromazgon deleted the lovro/config-defaults branch April 17, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maha-hajja maha-hajja maha-hajja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lovromazgon @maha-hajja