Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message headers to produced record #126

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Add message headers to produced record #126

merged 2 commits into from
Mar 19, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Mar 19, 2024 •
edited
Loading

Description

Adds message headers the the produced record. The headers are prefixed with kafka.header.. Also, the values, which are originally []byte are cast to strings.

Fixes #125.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review March 19, 2024 15:52
@hariso hariso requested a review from a team as a code owner March 19, 2024 15:52
@hariso hariso merged commit 2b54298 into main Mar 19, 2024
3 checks passed
@hariso hariso deleted the haris/add-headers branch March 19, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting Kafka-headers using the builtin Kafka connector
2 participants
@hariso @lovromazgon