Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove key field and update table field #135

Merged
merged 13 commits into from
Apr 24, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Apr 24, 2024

Description

Please include a summary of the change and what type of change it is (new feature, bug fix, refactoring, documentation).
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb mentioned this pull request Apr 24, 2024
7 tasks
@raulb raulb marked this pull request as ready for review April 24, 2024 16:07
@raulb raulb requested a review from a team as a code owner April 24, 2024 16:07
@raulb raulb self-assigned this Apr 24, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
source.go Outdated Show resolved Hide resolved
source/config.go Outdated Show resolved Hide resolved
Base automatically changed from raul/read-multiple-tables to main April 24, 2024 17:24
@raulb raulb force-pushed the lovro-raul/update-configuration-fields branch from 5232a02 to ba8bd45 Compare April 24, 2024 17:33
@raulb raulb requested a review from lovromazgon April 24, 2024 17:44
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@raulb raulb merged commit 13d4cad into main Apr 24, 2024
3 checks passed
@raulb raulb deleted the lovro-raul/update-configuration-fields branch April 24, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants