Protocol v2 tweaks (#94)

* extract specification into separate proto message

* return concrete types in client constructors

* rename Start to Open

* use config.Config

* generate mock for cplugin interfaces

cplugin/client/client.go

@@ -29,9 +29,9 @@ import (
 	"google.golang.org/grpc"
 )
 
-// NewClient creates a new plugin client. Path should point to the plugin
+// New creates a new plugin client. Path should point to the plugin
 // executable. The client will support both v1 and v2 of the connector protocol.
-func NewClient(
+func New(
 	logger hclog.Logger,
 	path string,
 	opts ...Option,

cplugin/destination.go

@@ -17,12 +17,15 @@ package cplugin
 import (
 	"context"
 
+	"github.com/conduitio/conduit-commons/config"
 	"github.com/conduitio/conduit-commons/opencdc"
 )
 
+//go:generate mockgen -destination=mock/destination.go -package=mock -mock_names=DestinationPlugin=DestinationPlugin . DestinationPlugin
+
 type DestinationPlugin interface {
 	Configure(context.Context, DestinationConfigureRequest) (DestinationConfigureResponse, error)
-	Start(context.Context, DestinationStartRequest) (DestinationStartResponse, error)
+	Open(context.Context, DestinationOpenRequest) (DestinationOpenResponse, error)
 	Run(context.Context, DestinationRunStream) error
 	Stop(context.Context, DestinationStopRequest) (DestinationStopResponse, error)
 	Teardown(context.Context, DestinationTeardownRequest) (DestinationTeardownResponse, error)
@@ -56,12 +59,12 @@ type DestinationRunStreamServer interface {
 }
 
 type DestinationConfigureRequest struct {
-	Config map[string]string
+	Config config.Config
 }
 type DestinationConfigureResponse struct{}
 
-type DestinationStartRequest struct{}
-type DestinationStartResponse struct{}
+type DestinationOpenRequest struct{}
+type DestinationOpenResponse struct{}
 
 type DestinationRunRequest struct {
 	Records []opencdc.Record
@@ -84,17 +87,17 @@ type DestinationTeardownRequest struct{}
 type DestinationTeardownResponse struct{}
 
 type DestinationLifecycleOnCreatedRequest struct {
-	Config map[string]string
+	Config config.Config
 }
 type DestinationLifecycleOnCreatedResponse struct{}
 
 type DestinationLifecycleOnUpdatedRequest struct {
-	ConfigBefore map[string]string
-	ConfigAfter  map[string]string
+	ConfigBefore config.Config
+	ConfigAfter  config.Config
 }
 type DestinationLifecycleOnUpdatedResponse struct{}
 
 type DestinationLifecycleOnDeletedRequest struct {
-	Config map[string]string
+	Config config.Config
 }
 type DestinationLifecycleOnDeletedResponse struct{}