[Schemas] Connector SDK: Create and get a schema from Conduit #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
force-pushed
the
haris/schema-support-connector-sdk
branch
from
53ca741 to
c042fc0
Compare
hariso
commented
May 31, 2024
hariso
changed the title
raulb
approved these changes
Jun 14, 2024
lovromazgon
reviewed
Jun 19, 2024
lovromazgon
reviewed
Jun 27, 2024
4 tasks
lovromazgon
reviewed
Jun 28, 2024
4 tasks
lovromazgon
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Good work @raulb, this already looks good. I'd still move some stuff around to make it just right 👌
* revert upgraded dependencies * make linter rules more strict, fix warnings * remove in memory service and doc.go * move internal/errors.go to pconnector, create separate package in pconduit, add tests in pconduit toproto/fromproto * rename cplugin.go to pconnector.go
raulb
approved these changes
Jul 2, 2024
lovromazgon
added a commit
that referenced
this pull request
Jul 3, 2024
* [Schemas] Schema service definition, conversion functions (#88) * update commons * [Schemas] Connector SDK: Create and get a schema from Conduit (#96) * [Schemas] Connector SDK: Create and get a schema from Conduit * remove replace * change port * add mocks * Get by name and version * update commons * add tests * a couple of tests, move around * update commons * move around * update commons * fix compilation * update commons * fix compilation * update commons * update commons * fix * add in memory schema service * simplify * comments * rename name to subject * rename package to pschema * typed mock * update commons * go mod tidy * update commons use schema * update to latest commons * simplify proto * unwrap error and create internal/errors.go * provide target to client * update proto schema * update schema type * remove dependency * update grpc_client * update service schema methods * update naming to follow convention * refactor leftover * Schema support proposed changes (#105) * revert upgraded dependencies * make linter rules more strict, fix warnings * remove in memory service and doc.go * move internal/errors.go to pconnector, create separate package in pconduit, add tests in pconduit toproto/fromproto * rename cplugin.go to pconnector.go --------- Co-authored-by: Raúl Barroso <[email protected]> Co-authored-by: Lovro Mažgon <[email protected]> * change how service suffix in proto files is linted --------- Co-authored-by: Haris Osmanagić <[email protected]> Co-authored-by: Raúl Barroso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of ConduitIO/conduit-connector-sdk#132.
Changes in this PR:
namefield tosubject.Depends on ConduitIO/conduit-commons#67.
Quick checks: