-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specgen: add more tests, rename connector to specification #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
changed the title
Specgen polishing
Specgen: add more tests, comments, fix linter issues
Nov 15, 2024
15 tasks
hariso
changed the title
Specgen: add more tests, comments, fix linter issues
specgen: add more tests, rename connector to specification
Nov 15, 2024
hariso
force-pushed
the
haris/specgen-polishing
branch
from
November 15, 2024 14:25
58a5056
to
b2839d8
Compare
Looks like this test is failing :(
|
The test is green now! |
raulb
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hariso
added a commit
that referenced
this pull request
Nov 28, 2024
Date: Thu Nov 28 12:44:48 2024 +0100 add open commit 2705320 Author: Haris Osmanagic <[email protected]> Date: Thu Nov 28 11:21:36 2024 +0100 destination_middleware_test.go commit b3f8172 Author: Haris Osmanagic <[email protected]> Date: Thu Nov 28 10:08:22 2024 +0100 fix source_test commit 6a53d24 Author: Haris Osmanagic <[email protected]> Date: Thu Nov 28 10:02:23 2024 +0100 fix source middleware commit 6cf5795 Author: Haris Osmanagic <[email protected]> Date: Wed Nov 27 15:39:46 2024 +0100 add test commit be36d59 Author: Haris Osmanagic <[email protected]> Date: Wed Nov 20 16:01:29 2024 +0100 fix source_middleware_test.go commit abdb4b7 Author: Haris Osmanagic <[email protected]> Date: Wed Nov 20 12:54:48 2024 +0100 fix DefaultDestinationMiddleware commit b07a4b5 Author: Haris Osmanagic <[email protected]> Date: Wed Nov 20 12:50:00 2024 +0100 linter commit 727489f Author: Haris Osmanagic <[email protected]> Date: Wed Nov 20 12:49:46 2024 +0100 comments commit 768c935 Author: Haris Osmanagic <[email protected]> Date: Wed Nov 20 12:46:33 2024 +0100 add comment commit d9f7f64 Author: Haris Osmanagic <[email protected]> Date: Wed Nov 20 12:42:57 2024 +0100 fix test expectation commit 9f5c6c2 Author: Haris Osmanagic <[email protected]> Date: Wed Nov 20 12:35:06 2024 +0100 handle schema type commit ddd70f5 Author: Haris Osmanagic <[email protected]> Date: Wed Nov 20 11:03:34 2024 +0100 workaround for schema type, optional dest mw param, fix validation commit fe751ca Author: Haris Osmanagic <[email protected]> Date: Tue Nov 19 15:17:30 2024 +0100 restructure commit 7318263 Author: Haris Osmanagic <[email protected]> Date: Tue Nov 19 14:59:25 2024 +0100 fix tests commit 04e9fd4 Author: Haris Osmanagic <[email protected]> Date: Tue Nov 19 14:06:01 2024 +0100 re-enable acceptance tests commit c5174a6 Author: Haris Osmanagic <[email protected]> Date: Tue Nov 19 13:08:09 2024 +0100 partial specs test commit dcc08ed Author: Haris Osmanagic <[email protected]> Date: Tue Nov 19 12:48:02 2024 +0100 write yaml, overwrite existiang source and destination commit 8af981f Author: Haris Osmanagic <[email protected]> Date: Tue Nov 19 12:45:18 2024 +0100 more tests, restructure commit 1755bac Author: Haris Osmanagic <[email protected]> Date: Tue Nov 19 12:37:09 2024 +0100 revert changes to input file commit dabaf2e Author: Haris Osmanagic <[email protected]> Date: Mon Nov 18 19:12:42 2024 +0100 update test commit 2b4394a Author: Haris Osmanagic <[email protected]> Date: Mon Nov 18 19:09:57 2024 +0100 simplify commit ab77011 Author: Haris Osmanagic <[email protected]> Date: Mon Nov 18 19:08:12 2024 +0100 TestWriteAndCombine commit f51b771 Author: Haris Osmanagić <[email protected]> Date: Mon Nov 18 18:22:24 2024 +0100 specgen: add more tests, rename connector to specification (#206) commit 07483f5 Author: Lovro Mažgon <[email protected]> Date: Fri Nov 15 15:06:29 2024 +0100 Specgen (#198) * specgen spike * start nicer rewrite of specgen * support for parsing builtin params * support for time.Duration * support types in different packages * support underlying type * better tests * specgen specification parsing and default overwriting * add support for destinations * fix test * add parsing and validation of config * adjust most destination tests --------- Co-authored-by: Haris Osmanagic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
greater-than: 100.00000
, now:greater-than: 100
)Related issues:
Quick checks: