Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for connector.yaml #63

Merged
merged 12 commits into from
Feb 4, 2025
Merged

Support for connector.yaml #63

merged 12 commits into from
Feb 4, 2025

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Dec 9, 2024 •
edited by raulb
Loading

Description

Fixes #57.

Caution

!!! Should be merged only when the SDK is released!

Combines:

Quick checks:

  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review January 8, 2025 12:21
@hariso hariso requested a review from a team as a code owner January 8, 2025 12:21
@hariso hariso self-assigned this Jan 8, 2025
@raulb
Copy link
Member

raulb commented Jan 8, 2025

@hariso this one has some merge conflicts. I'll review in the meantime.

maha-hajja
maha-hajja approved these changes Jan 15, 2025
View reviewed changes
@raulb raulb mentioned this pull request Jan 21, 2025
Closed
hariso and others added 2 commits February 4, 2025 16:33
@hariso @lovromazgon
specgen and readmegen improvements (#75)
60ed5b1 
* specgen and readmegen improvements

* use readmegen in the readme

* use yaml

* fix setup.sh

* make generate

* go mod tidy

* pr feedback

* note about dev

* re-generate

* mention make install-tools

* handle errors in bump_version, use yq

* check if conn-sdk-cli is installed

* Update Makefile

* Update README.md

---------

Co-authored-by: Lovro Mažgon <[email protected]>
@lovromazgon
Update README.md
13117eb
lovromazgon
lovromazgon approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI in the last commit I simplified the quick start part. I'm even thinking we could remove the connector.yaml instructions in the quick start, that's really part of the development process, not part of the quick start.

@lovromazgon lovromazgon enabled auto-merge (squash) February 4, 2025 16:19
@lovromazgon lovromazgon merged commit fde3bca into main Feb 4, 2025
3 checks passed
@lovromazgon lovromazgon deleted the specgen branch February 4, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

@lovromazgon lovromazgon lovromazgon approved these changes

@maha-hajja maha-hajja maha-hajja approved these changes

Assignees

@hariso hariso

Labels
None yet
Projects
Conduit Main
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

specgen: generate specification from connector.yaml
4 participants
@hariso @raulb @lovromazgon @maha-hajja