add support for kafka wrapper #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
reviewed
Mar 20, 2024
| switch { | ||
| case | ||
| strings.HasPrefix(c.Plugin, "builtin"), | ||
| strings.Contains(c.Plugin, "conduit-kafka-connect-wrapper"): |
There was a problem hiding this comment.
Nitpick: maybe use c.Plugin == KafkaConnectWrapper?
There was a problem hiding this comment.
@hariso yea, I think we need to rethink how this works lol
e.g. if that plugin is provided we could invoke another image to pull the necessary stuff.
hariso
approved these changes
Mar 20, 2024
raulb
approved these changes
Apr 1, 2024
| @@ -6,7 +6,7 @@ spec: | |||
| running: true | |||
| name: generator.log | |||
| description: generator pipeline | |||
| image: ghcr.io/conduitio/conduit | |||
| image: meroxa/conduit-kafka-connect-wrapper | |||
There was a problem hiding this comment.
Suggested change
| image: meroxa/conduit-kafka-connect-wrapper | |
| image: meroxa/conduit-kafka-connect-wrapper |
|
Going to close this @hariso, we can reopen this when we need it. |
|
@lyuboxa sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and what type of change it is (new feature, bug fix, refactoring, documentation).
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Quick checks: