Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade pipelines file generation to v2.2 #22

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Upgrade pipelines file generation to v2.2 #22

merged 2 commits into from
Sep 19, 2024

Conversation

lyuboxa
Copy link
Collaborator

@lyuboxa lyuboxa commented Sep 18, 2024 •
edited
Loading

Description

  • Remove processors.Type
  • Validate processors.Plugin is not empty

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lyuboxa
Upgrade pipelines file generation to v2.2
3c22e88 
* Remove `processors.Type`
* Validate `processors.Plugin` is not empty
@lyuboxa lyuboxa requested a review from a team as a code owner September 18, 2024 18:30
hariso
hariso approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

api/v1alpha/conduit_validator.go Outdated Show resolved Hide resolved
@lyuboxa lyuboxa merged commit 32001ba into main Sep 19, 2024
4 checks passed
@lyuboxa lyuboxa deleted the lk/update-crd-with-latest-conduit branch September 19, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyuboxa @hariso