Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pipeline config files section #48

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Mar 8, 2024

Copy link

cloudflare-workers-and-pages bot commented Mar 8, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ba4b11
Status: ✅  Deploy successful!
Preview URL: https://281462a5.conduit-site.pages.dev
Branch Preview URL: https://maha-update-pipeline-config.conduit-site.pages.dev

View logs

Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wonder if to not block this PR, we could not add the link to building processors and add the reference afterwards once this new page is created.

What do you think? @maha-hajja @lovromazgon

@maha-hajja maha-hajja requested review from lovromazgon and raulb March 11, 2024 18:35
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/pipeline-configuration-files/specifications.mdx Outdated Show resolved Hide resolved
@maha-hajja maha-hajja requested a review from a team as a code owner March 12, 2024 16:04
@maha-hajja maha-hajja merged commit 678b960 into main Mar 12, 2024
1 check passed
@maha-hajja maha-hajja deleted the maha/update-pipeline-config-files branch March 12, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants