Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(processors): How to use standalone processors #59

Merged
merged 12 commits into from
Mar 21, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Mar 15, 2024

This pull-request adds a new index page for processors that should give users a quick overview on how to use standalone processors in Conduit.

Part of ConduitIO/conduit#1422

@raulb raulb requested a review from a team as a code owner March 15, 2024 15:56
@raulb raulb self-assigned this Mar 15, 2024
Copy link

cloudflare-workers-and-pages bot commented Mar 15, 2024

Deploying conduit-site with  Cloudflare Pages  Cloudflare Pages

Latest commit: 79b7a30
Status: ✅  Deploy successful!
Preview URL: https://21b94cbe.conduit-site.pages.dev
Branch Preview URL: https://raul-how-to-use-standalone-p.conduit-site.pages.dev

View logs

docs/processors/standalone/index.mdx Outdated Show resolved Hide resolved
docs/processors/standalone/index.mdx Outdated Show resolved Hide resolved
docs/processors/standalone/index.mdx Outdated Show resolved Hide resolved
docs/processors/standalone/index.mdx Outdated Show resolved Hide resolved
@raulb raulb requested a review from lovromazgon March 19, 2024 21:07
@raulb raulb force-pushed the raul/how-to-use-standalone-processors branch from bad6cdd to b570bf5 Compare March 19, 2024 21:54
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @raulb! My comments are nitpicks only.

@brettgoulder
Copy link
Contributor

brettgoulder commented Mar 20, 2024

While you're in here, can you fix a link on standalone/building.mdx

The link for Standalone processors under the hood (WASM) should go to /docs/processors/standalone/how-it-works.

Miss you all!

docs/processors/getting-started.mdx Outdated Show resolved Hide resolved
docs/processors/standalone/index.mdx Outdated Show resolved Hide resolved
docs/processors/standalone/index.mdx Outdated Show resolved Hide resolved
docs/processors/standalone/index.mdx Outdated Show resolved Hide resolved
@brettgoulder
Copy link
Contributor

@maha-hajja I think the .mdx also needs to be removed from that link

@maha-hajja
Copy link
Contributor

@brettgoulder fixed :D Thank you!
it's lovely seeing that you're keeping up with Conduit 🙌

@raulb
Copy link
Member Author

raulb commented Mar 21, 2024

Hello @brettgoulder !

@raulb raulb enabled auto-merge (squash) March 21, 2024 14:28
@raulb raulb merged commit 3d3cb16 into main Mar 21, 2024
1 check passed
@raulb raulb deleted the raul/how-to-use-standalone-processors branch March 21, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants