Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conditional processor execution #1349

Merged
merged 21 commits into from
Jan 26, 2024
Merged

conditional processor execution #1349

merged 21 commits into from
Jan 26, 2024

Conversation

maha-hajja
Copy link
Contributor

@maha-hajja maha-hajja commented Jan 25, 2024

Description

added a "condition" field for the processor instance, made sure to assign that field by gRPC and by pipeline config files when creating processors.
bumped the pipeline config file minor version from 2.0 to 2.1

Fixes #1344
Fixes #1345

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@maha-hajja maha-hajja requested a review from a team as a code owner January 25, 2024 07:38
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me! Left a couple of nitpicks only!

pkg/orchestrator/orchestrator.go Show resolved Hide resolved
proto/api/v1/api.proto Show resolved Hide resolved
@maha-hajja maha-hajja requested a review from hariso January 26, 2024 00:36
@maha-hajja maha-hajja merged commit 2c3dfaf into main Jan 26, 2024
5 checks passed
@maha-hajja maha-hajja deleted the maha/conditional-processor branch January 26, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants