Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unwrap openCDC records on create and update #1362

Merged
merged 2 commits into from
Feb 5, 2024
Merged

fix: unwrap openCDC records on create and update #1362

merged 2 commits into from
Feb 5, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Feb 5, 2024

Description

Fixes #1359

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb changed the title fix: unwrap delete opencdc records fix: unwrap opencdc records when after is nil Feb 5, 2024
@raulb raulb changed the title fix: unwrap opencdc records when after is nil fix: unwrap openCDC records on create and update Feb 5, 2024
@raulb raulb marked this pull request as ready for review February 5, 2024 14:32
@raulb raulb requested a review from a team as a code owner February 5, 2024 14:32
@raulb raulb requested a review from hariso February 5, 2024 14:55
@raulb raulb merged commit f71d078 into main Feb 5, 2024
3 checks passed
@raulb raulb deleted the raul/fix-uwrap-delete-opencdc branch February 5, 2024 15:21
@raulb raulb mentioned this pull request Feb 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: can't unwrap a record on delete using opencdc
2 participants
@raulb @hariso