Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links about referencing fields in processors #1424

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Update links about referencing fields in processors #1424

merged 4 commits into from
Mar 12, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Mar 8, 2024 •
edited by lovromazgon
Loading

Description

Part of #1422.

Related to ConduitIO/conduit-site#50 (it creates the page to which we link).

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso mentioned this pull request Mar 8, 2024
Closed
19 tasks
@raulb raulb changed the title Update links about referecing fields in processors Update links about referencing fields in processors Mar 12, 2024
@lovromazgon lovromazgon marked this pull request as ready for review March 12, 2024 16:59
@lovromazgon lovromazgon requested a review from a team as a code owner March 12, 2024 16:59
raulb
raulb approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving though I left a suggestion of something missing. Once that's done, this is ready to ship 👍

pkg/plugin/processor/builtin/impl/filter.go Show resolved Hide resolved
pkg/plugin/processor/builtin/internal/exampleutil/specs/avro.decode.json Show resolved Hide resolved
pkg/plugin/processor/builtin/internal/exampleutil/specs/base64.decode.json Outdated Show resolved Hide resolved
@lovromazgon
Copy link
Member

I sneaked in another change - I renamed all examples_test.go and examples_exporter_test.go files (used to generate processor specs), they now have the prefix z_ which makes them alphabetically the last file in the folder, meaning that go:generate will process them last. Why is this good? They depend on the code that gets produced by paramgen, so this way we make sure that paramgen runs first.

@lovromazgon lovromazgon mentioned this pull request Mar 12, 2024
Merged
@lovromazgon lovromazgon enabled auto-merge (squash) March 12, 2024 18:31
@lovromazgon lovromazgon merged commit 61c8af3 into main Mar 12, 2024
3 checks passed
@lovromazgon lovromazgon deleted the haris/update-links branch March 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon left review comments

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hariso @lovromazgon @raulb