Migrate to Conduit Commons utils #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovromazgon
added a commit
that referenced
this pull request
Jul 1, 2024
* update standalone plugin to use connector protocol v2 * update destination acceptance tests * update builtin plugin adapter * move builtin/v1 to builtin * update connector package, still missing source tests * source tests * update pkg/pipeline * fix pkg/orchestrator * conduit compiles again * generate typed mocks * update protocol and sdk, rename cplugin to pconnector * fix linter warning * test getting stream without calling run * make destination plugin mock nicer * remove redundant mock options * organize imports * clone response in builtin plugins * add builtin generator connector * include builtin connectors (only postgres missing now) * add comment about cloning requests and responses * address review comments * update postgres connector, address review comments * update postgres, s3 and connector sdk * Migrate to Conduit Commons utils (#1673) * remove obsolete foundation packages * replace removed packages with alternatives in conduit-commons * user errors.Join instead of multierror * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes a few foundation packages in favor of implementations in conduit-commons:
pkg/foundation/csyncreplaced withcsyncpkg/foundation/cchanreplaced withcchanpkg/foundation/rollbackreplaced withrollbackpkg/foundation/semaphorereplaced withsemaphorepkg/foundation/multierrorreplaced withcerrors.Joincerrors.ForEachwas added for looping through joined errorsDepends on #1622.
Part of #1433.
Quick checks: