Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ecdysis to Conduit CLI #1983

Merged
merged 42 commits into from
Dec 18, 2024
Merged

feat: add ecdysis to Conduit CLI #1983

merged 42 commits into from
Dec 18, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Nov 19, 2024 •
edited
Loading

Description

Fixes #1981

⚠️ Remove support for pipelines.exit-on-error (announced here)

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb marked this pull request as ready for review November 21, 2024 15:34
@raulb raulb requested a review from a team as a code owner November 21, 2024 15:34
@raulb raulb marked this pull request as draft November 21, 2024 16:28
@raulb raulb marked this pull request as ready for review November 26, 2024 12:28
hariso
hariso reviewed Nov 26, 2024
View reviewed changes
cmd/conduit/root/root.go Outdated Show resolved Hide resolved
hariso
hariso reviewed Nov 27, 2024
View reviewed changes
cmd/conduit/root/init.go Outdated Show resolved Hide resolved
@raulb raulb mentioned this pull request Dec 2, 2024
Merged
@raulb raulb requested a review from hariso December 17, 2024 21:07
@raulb raulb self-assigned this Dec 17, 2024
hariso
hariso reviewed Dec 18, 2024
View reviewed changes
cmd/conduit/root/root.go Outdated Show resolved Hide resolved
hariso
hariso reviewed Dec 18, 2024
View reviewed changes
cmd/conduit/root/root_test.go Outdated Show resolved Hide resolved
cmd/conduit/root/root.go Show resolved Hide resolved
cmd/conduit/root/root.go Outdated Show resolved Hide resolved
cmd/conduit/root/root.go Show resolved Hide resolved
@raulb raulb mentioned this pull request Dec 18, 2024
Open
@raulb raulb merged commit 5360931 into main Dec 18, 2024
3 checks passed
@raulb raulb deleted the raul/add-ecdysis branch December 18, 2024 15:31
@raulb raulb mentioned this pull request Dec 18, 2024
Open
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees

@raulb raulb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate ecdysis with existing CLI
2 participants
@raulb @hariso