Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add conduit config #2033

Merged
merged 10 commits into from
Dec 19, 2024
Merged

feat: add conduit config #2033

merged 10 commits into from
Dec 19, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Dec 19, 2024

Description

Fixes #2017

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb requested a review from a team as a code owner December 19, 2024 10:44
@raulb raulb self-assigned this Dec 19, 2024
hariso
hariso approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, Raúl, thanks! I had a question, but I don't think it should prevent us from merging this PR.

cmd/conduit/root/config.go Show resolved Hide resolved
@raulb raulb merged commit 48917b5 into main Dec 19, 2024
3 checks passed
@raulb raulb deleted the cli-config branch December 19, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees

@raulb raulb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: conduit config
2 participants
@raulb @hariso