transactions wrap whole SetRequest processing #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomiklos
reviewed
Dec 13, 2023
|
|
||
| @abstractmethod | ||
| def delete(self, prefix, paths): | ||
| def update_transaction(self, prefix) -> ContextManager[UpdateTransaction]: |
There was a problem hiding this comment.
update_transaction here imho reads like "verb, subject", maybe rename? handler() / manager() or similar...
There was a problem hiding this comment.
I was considering a different name, but note it is a context manager, so its usage is like
with update_transaction(prefix) as trans:
....
and words like "handler" would be at least redundant.
src/confd_gnmi_servicer.py
Outdated
| @@ -167,8 +167,8 @@ def Set(self, request, context): | |||
| self.verify_updates_encoding_supported(request.update, adapter, context) | |||
| # TODO for now we do not process replace list | |||
| # TODO: changes should be part of one transaction (gNMI spec. 3.4.3) | |||
There was a problem hiding this comment.
this one comment line is now resolved? (with .. as trans:)
There was a problem hiding this comment.
right, will remove
micnovak
approved these changes
Dec 14, 2023
fixes #28 Signed-off-by: Martin Volf <[email protected]>
martin-volf
force-pushed
the
mv/trans-order
branch
from
80976ce
to
dfd500c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapters are required to provide context manager for transaction contexts; the update operations are then invoked on the transaction.