-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete in stream telemetry - in demo + test #34
Conversation
a7158fb
to
b0d753f
Compare
minor refactoring stream telemetry delete in demo adapter tests for delete in stream telemetry Signed-off-by: Michal Novak <[email protected]>
b0d753f
to
aac7cb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The base test classes contain a lot of dependencies on the demo adapter (there were some already, but this change introduces a lot more). It is "just" a test, so I guess it is acceptable, but still.
@@ -37,6 +45,7 @@ def fix_method(self, request): | |||
self.set_adapter_type() | |||
self.server = ConfDgNMIServicer.serve(adapter_type=self.adapter_type, insecure=True) | |||
self.client = ConfDgNMIClient(insecure=True) | |||
GnmiDemoServerAdapter.fill_demo_db() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this code specific to the demo adapter? Also, it looks like a broader-scoped fixture, not a function fixture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demo db is currently also used for ConfD tests (contains paths to test)
I think only new types (classes) for change list were imported (newly) |
Signed-off-by: Michal Novak <[email protected]>
Signed-off-by: Michal Novak <[email protected]>
Signed-off-by: Michal Novak <[email protected]>
Signed-off-by: Michal Novak <[email protected]>
minor refactoring
stream telemetry delete in demo adapter
tests for delete in stream telemetry