delete in stream telemetry - in demo + test #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micnovak
force-pushed
the
micnovak/delete_tests
branch
from
a7158fb
to
b0d753f
Compare
minor refactoring stream telemetry delete in demo adapter tests for delete in stream telemetry Signed-off-by: Michal Novak <[email protected]>
micnovak
force-pushed
the
micnovak/delete_tests
branch
from
b0d753f
to
aac7cb3
Compare
martin-volf
reviewed
Jan 9, 2024
| @@ -37,6 +45,7 @@ def fix_method(self, request): | |||
| self.set_adapter_type() | |||
| self.server = ConfDgNMIServicer.serve(adapter_type=self.adapter_type, insecure=True) | |||
| self.client = ConfDgNMIClient(insecure=True) | |||
| GnmiDemoServerAdapter.fill_demo_db() | |||
There was a problem hiding this comment.
Is this code specific to the demo adapter? Also, it looks like a broader-scoped fixture, not a function fixture.
There was a problem hiding this comment.
demo db is currently also used for ConfD tests (contains paths to test)
I think only new types (classes) for change list were imported (newly) |
jomiklos
reviewed
Jan 9, 2024
Signed-off-by: Michal Novak <[email protected]>
Signed-off-by: Michal Novak <[email protected]>
Signed-off-by: Michal Novak <[email protected]>
Signed-off-by: Michal Novak <[email protected]>
jomiklos
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor refactoring
stream telemetry delete in demo adapter
tests for delete in stream telemetry