added config reset test fixture (empty for Demo) #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Volf <[email protected]>
micnovak
reviewed
Jan 5, 2024
| @@ -13,3 +13,6 @@ class TestGrpcDemo(AdapterTests): | |||
|
|
|||
| def set_adapter_type(self): | |||
| self.adapter_type = AdapterType.DEMO | |||
|
|
|||
| def _do_reset_cfg(self): | |||
There was a problem hiding this comment.
Disadvantage of making new class. just for Set. Perhaps there can be common (abstract) ConfDTests class, so _do_reset_cfg is implemented only once. And functionality could be implemented in this function (no need for reset_confd_config()).
| @@ -73,6 +73,13 @@ def mk_gnmi_if_path(path_str, if_state_str="", if_id=None): | |||
| path_str = path_str.format(if_state_str, if_id) | |||
| return make_gnmi_path(path_str) | |||
|
|
|||
| def _do_reset_cfg(self): | |||
There was a problem hiding this comment.
Why underscore, as it is not private for the class? It is overridden in derived classes.
micnovak
reviewed
Jan 5, 2024
| def _do_reset_cfg(self): | ||
| raise NotImplementedError | ||
|
|
||
| @pytest.fixture |
There was a problem hiding this comment.
Thinking about it, do we need extra fixture? I know it is slightly different, but for now adding _do_reset_cfg into
existing fixture def fix_method(self, request): would do.
micnovak
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
reset_cfgfixture was generalized for the full configuration and other tests that (potentially) change configuration (i.e. alltest_set*). Implementation for Demo adapter tests is left empty for now.