fix ci failures

Cargo.toml

@@ -32,7 +32,7 @@ pending_review_screen = []
 curve = ["secp256k1"]
 flags = "0"
 path = ["44'/503'"]
-name = "Conflux"
+name = "Conflux Core"
 
 [package.metadata.ledger.nanox]
 icon = "icons/cfx_14.gif"

README.md

@@ -4,8 +4,8 @@ This is the Conflux Ledger device app, which is developed in Rust. This project
 
 ## Work to be done
 
-1. Unit conversion in the tx show UI
+1. Unit conversion in the tx show UI ✅
 2. Setting read and write: c app is through action
-3. Icons for stax and flex
+3. Icons for stax and flex ✅
 4. More test cases
-5. Nanox rlp compile issue
+5. Nanox rlp compile issue: need manual impl rlp decode

docs/APDU.md

@@ -24,5 +24,5 @@ Status words tend to be similar to common [APDU responses](https://www.eftlab.co
 
 | Field name | Length (bytes) | Description |
 | --- | --- | --- |
-| RData | var | Reponse data (can be empty) |
+| RData | var | Response data (can be empty) |
 | SW | 2 | Status word containing command processing status (e.g. `0x9000` for success) |

src/cfx_addr/consts.rs

@@ -40,11 +40,11 @@ pub const TESTNET_PREFIX: &str = "cfxtest";
 pub const NETWORK_ID_PREFIX: &str = "net";
 
 // address types
-pub const ADDRESS_TYPE_BUILTIN: &'static str = "builtin";
-pub const ADDRESS_TYPE_CONTRACT: &'static str = "contract";
-pub const ADDRESS_TYPE_NULL: &'static str = "null";
-pub const ADDRESS_TYPE_UNKNOWN: &'static str = "unknown";
-pub const ADDRESS_TYPE_USER: &'static str = "user";
+pub const ADDRESS_TYPE_BUILTIN: &str = "builtin";
+pub const ADDRESS_TYPE_CONTRACT: &str = "contract";
+pub const ADDRESS_TYPE_NULL: &str = "null";
+pub const ADDRESS_TYPE_UNKNOWN: &str = "unknown";
+pub const ADDRESS_TYPE_USER: &str = "user";
 
 // These two network_ids are reserved.
 pub const RESERVED_NETWORK_IDS: [u64; 2] = [1, 1029];

src/consts.rs

@@ -45,4 +45,4 @@ pub const APP_FLAG_BLIND_SIGNING_ENABLED: usize = 0x01;
 
 pub const APP_FLAG_DETAILED_DISPLAY_ENABLED: usize = 0x02;
 
-pub const PERSONAL_SIGN_PREFIX: &'static str = "\x19Conflux Signed Message:\n";
+pub const PERSONAL_SIGN_PREFIX: &str = "\x19Conflux Signed Message:\n";

src/main.rs

@@ -170,7 +170,7 @@ impl TryFrom<ApduHeader> for Instruction {
 #[cfg(any(target_os = "stax", target_os = "flex"))]
 fn show_status_and_home_if_needed(ins: &Instruction, tx_ctx: &mut TxContext, status: &AppSW) {
     let (show_status, status_type) = match (ins, status) {
-        (Instruction::GetPubkey { display: true }, AppSW::Deny | AppSW::Ok) => {
+        (Instruction::GetPubkey { display: true, return_chain_code: _ }, AppSW::Deny | AppSW::Ok) => {
             (true, StatusType::Address)
         }
         (Instruction::SignTx { .. }, AppSW::Deny | AppSW::Ok) if tx_ctx.finished() => {

tests/application_client/command_sender.py

@@ -23,7 +23,7 @@ class P2(IntEnum):
     P2_LAST = 0x00
     # Parameter 2 for more APDU to receive.
     P2_MORE = 0x80
-
+    # Parameter 2 for true.
     P2_TRUE = 0x01
 
 class InsType(IntEnum):
@@ -92,12 +92,16 @@ def get_public_key(self, path: str) -> RAPDU:
 
 
     @contextmanager
-    def get_public_key_with_confirmation(self, path: str, chain_id: int) -> Generator[None, None, None]:
+    def get_public_key_with_confirmation(self, 
+                                         path: str, 
+                                         chain_id: int
+                                         ) -> Generator[None, None, None]:
         with self.backend.exchange_async(cla=CLA,
                                          ins=InsType.GET_PUBLIC_KEY,
                                          p1=P1.P1_CONFIRM,
                                          p2=P2.P2_TRUE,
-                                         data=pack_derivation_path(path) + chain_id.to_bytes(4, 'big')) as response:
+                                         data=pack_derivation_path(path) + chain_id.to_bytes(4, 'big'),
+                                         ) as response:
             yield response
 
 

tests/application_client/response_unpacker.py

@@ -22,7 +22,7 @@ def unpack_get_app_name_response(response: bytes) -> str:
 #            PATCH (1)
 def unpack_get_version_response(response: bytes) -> Tuple[int, int, int]:
     assert len(response) == 4
-    flag, major, minor, patch = unpack("BBBB", response)
+    _, major, minor, patch = unpack("BBBB", response)
     return (major, minor, patch)
 
 # Unpack from response:

tests/application_client/transaction.py

@@ -7,8 +7,10 @@ class TransactionError(Exception):
 
 class Transaction:
     def __init__(self, **kwargs: TxParam):
-
         self.tx = CfxTransaction.from_dict(kwargs)
 
     def serialize(self) -> bytes:
         return self.tx.encode(allow_unsigned=True)
+
+    def get_internal_tx(self) -> dict:
+        return self.tx.to_dict()