Remove asyncore #2953
Open
Remove asyncore #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darwintree
force-pushed
the
remove-asynccore
branch
from
037b1bb
to
82d2787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated
asyncorein favor ofasyncio.This modification is based on bitcoin's commit bitcoin/bitcoin@fa87da2#diff-0be0a11a850d4efed38840c744a0c1847296d87a97e1e405e1df08781d2d4dbf.
This commit also removes the
p2p.stateproperty in favor ofp2p.is_connected(following bitcoin's change).Changes shall be done in the submodule
extra-test-toolkitswherenetwork_thread_start()should be removedThis change is