Adding A Historical Visits MUST Not Allow Use Of Today's Date or a fu… #111
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture date to submit this visit
sherrif10
changed the title
druchniewicz
reviewed
Feb 5, 2025
| calendar.add(Calendar.DAY_OF_YEAR, -1) | ||
| datePicker.maxDate = calendar.timeInMillis | ||
| // historical visits are restricted to dates strictly before today. | ||
| datePicker.updateDate( |
There was a problem hiding this comment.
Is it required? we just want set "yesterday" as max date in calendar - looks like this "calendar.add(Calendar.DAY_OF_YEAR, -1)" does the trick and rest of code is not needed? but correct me if I'm wrong
| @@ -469,7 +469,7 @@ | |||
| <string name="visits_overview_client_name_column_label">Child Name</string> | |||
| <string name="visits_overview_details_visit_date_label">Visit Date:</string> | |||
| <string name="visits_overview_details_scheduled_visit_date_label">Scheduled Visit Date:</string> | |||
| <string name="visits_overview_details_historical_visit_date_label">Historical Visit Date:</string> | |||
| <string name="visits_overview_details_historical_visit_date_label">Today\'s Visit Date:</string> | |||
There was a problem hiding this comment.
this label change does not make sense. This label is displayed in historical visits so it will be shown only for past visits so label "Today's Visit date" does not make sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ture date to submit this visit
https://sd-vxnaid.atlassian.net/browse/VRVU-287 cc @druchniewicz
What is fixed.