-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrections and refresh to Wallet Setup section #140
Conversation
…rrected, improved Corrected Wallet Setup instructions re: MM Mobile, augmented with more links and instructions regarding setting up MM and orienting users as to what and how they can do things on Linea.
Updated the wallet setup section to have accurate instructions regarding MM Mobile, and lots more links and resources.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The linter errors are timeouts on links that are, nevertheless, valid; please ignore. |
Added contract addresses for Message Bridge and an entry for ETH.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly suggestions but also a typo or two that do need fixing before we merge.
I don't understand what happened to this PR. I am going to literally copy my work to a different branch and try this again, we'll see if we keep having the problem. If we do, we need to escalate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent proofreading, thank you sir!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently passing everything except links that we know are actually valid. Let's go with this.
Looks like there's a conflict? |
Pull request checklist
Before creating the PR
Make sure that:
Describe the change
The Wallet Setup section was quite basic, and actually had incorrect information regarding MetaMask Mobile. I've fleshed it out significantly, added a lot more links, etc.
Issue fixed
No current issue exists
Impacted parts
For content changes:
After creating your PR and tests have finished
Make sure that: