Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections and refresh to Wallet Setup section #140

Merged
merged 25 commits into from
Jun 23, 2023
Merged

Conversation

mapachurro
Copy link
Collaborator

Pull request checklist

Before creating the PR

Make sure that:

Describe the change

The Wallet Setup section was quite basic, and actually had incorrect information regarding MetaMask Mobile. I've fleshed it out significantly, added a lot more links, etc.

Issue fixed

No current issue exists

Impacted parts

For content changes:

  • [ x] Documentation content
  • Documentation page organization

After creating your PR and tests have finished

Make sure that:

  • You've fixed any issues raised by the tests.
  • You've previewed your changes on Vercel below.

…rrected, improved

Corrected Wallet Setup instructions re: MM Mobile, augmented with more links and instructions
regarding setting up MM and orienting users as to what and how they can do things on Linea.
Updated the wallet setup section to have accurate instructions regarding MM Mobile, and lots more
links and resources.
@vercel
Copy link

vercel bot commented Jun 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2023 1:43pm

@mapachurro
Copy link
Collaborator Author

The linter errors are timeouts on links that are, nevertheless, valid; please ignore.

WenLanBan

This comment was marked as duplicate.

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly suggestions but also a typo or two that do need fixing before we merge.

docs/use-linea/explore/use-asmatch.md Outdated Show resolved Hide resolved
docs/use-linea/explore/use-patch.md Outdated Show resolved Hide resolved
docs/use-linea/explore/use-patch.md Outdated Show resolved Hide resolved
docs/use-linea/explore/use-readon.md Outdated Show resolved Hide resolved
docs/use-linea/set-up-your-wallet.md Show resolved Hide resolved
docs/use-linea/set-up-your-wallet.md Outdated Show resolved Hide resolved
@mapachurro
Copy link
Collaborator Author

I don't understand what happened to this PR. I am going to literally copy my work to a different branch and try this again, we'll see if we keep having the problem. If we do, we need to escalate

Copy link
Collaborator Author

@mapachurro mapachurro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent proofreading, thank you sir!

docs/use-linea/explore/use-readon.md Outdated Show resolved Hide resolved
docs/use-linea/set-up-your-wallet.md Show resolved Hide resolved
Copy link
Collaborator Author

@mapachurro mapachurro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently passing everything except links that we know are actually valid. Let's go with this.

@emilyJLin95
Copy link
Contributor

Looks like there's a conflict?
Once it's resolved I can approve and merge

@mapachurro mapachurro merged commit e13319d into main Jun 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants