Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(added postman-sdk documentation): added postman-sdk documentation #178

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

cedrabner
Copy link
Contributor

@cedrabner cedrabner commented Jun 23, 2023

Pull request checklist

Use the following template to make sure your PR fits the ConsenSys documentation standard.

Before creating the PR

Make sure that:

Describe the change

Updated the links that went to blockscout and changed them to the goerli.lineascan.build

Issue fixed

No current issue exists

Impacted parts

For content changes:

  • [ x] Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

  • You've fixed any issues raised by the tests.
  • You've previewed your changes on Vercel below.

@vercel
Copy link

vercel bot commented Jun 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 7:06pm

docs/developers/quickstart/postman-sdk.md Outdated Show resolved Hide resolved
docs/developers/quickstart/postman-sdk.md Outdated Show resolved Hide resolved
docs/developers/quickstart/postman-sdk.md Outdated Show resolved Hide resolved
postman sdk typo fixes
Copy link
Collaborator

@mapachurro mapachurro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah! I'm excited for this.

Copy link
Collaborator

@mapachurro mapachurro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, Chris had addressed Emily's concerns here. We should continue thinking about how best to structure the docs overall.

Copy link
Contributor

@emilyJLin95 emilyJLin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cedrabner cedrabner merged commit 5254417 into main Jun 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants