-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat add random mask to groth16 commitment #1245
Conversation
@ivokub |
I made the test to expect provers success instead. It can be useful in the future to catch regressions. I think it is useful that we can have prover assigned random commitment if we don't commit to anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes all sense! I added a regression test also.
This PR adds a random mask to the BSB22 commitments in order to make them hiding.
It is achieved simply by randomizing a new variable and adding it to the commitment.
Type of change
Checklist:
golangci-lint
does not output errors locally