Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merkle damgard and poseidon2 #1407

Merged
merged 16 commits into from
Feb 17, 2025
Merged

feat: merkle damgard and poseidon2 #1407

merged 16 commits into from
Feb 17, 2025

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Jan 31, 2025

Companion to Consensys/gnark-crypto#623
This PR introduces a generic Merkle Damgard construction and uses it to instantiate Poseidon2 as a full hash function.
(Parameters only for BLS12-377)

@Tabaie Tabaie requested review from gbotrel and removed request for gbotrel February 5, 2025 16:39
@Tabaie Tabaie marked this pull request as draft February 5, 2025 16:52
@Tabaie Tabaie marked this pull request as ready for review February 11, 2025 15:22
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored a bit so that it would align with gnark-crypto (method names, documentation, referring to default parameters from gnark-crypto etc.).

Otherwise, looks good. I'm not so sure about the test utility for single function circuits.

@ivokub ivokub mentioned this pull request Feb 17, 2025
16 tasks
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now!

@Tabaie Tabaie merged commit e55bdc2 into master Feb 17, 2025
5 checks passed
@Tabaie Tabaie deleted the feat/poseidon2-hash branch February 17, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants