-
Notifications
You must be signed in to change notification settings - Fork 435
Perf/gkr/solvable var #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tabaie
wants to merge
70
commits into
master
Choose a base branch
from
perf/gkr/solvable-var
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Perf/gkr/solvable var #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A "solvable" variable in a polynomial is one that only occurs in monomials of total degree 1, and with a non-zero coefficient. Its value can be uniquely determined from the polynomial's and those of the other variables. For example, in$\ f(x,y,z) = 2x + yz $ , $\ x $ is a solvable variable because we can get $\ x = \frac {f(x,y,z) - yz} 2 $ .
In GKR, at the end of the sumcheck subprotocol for wire$\ w $ , we end up with a claim of the form $\ w(r_1, r_2, \dots, r_n) = y $ , where the symbol $\ w$ represents the current wire, as well as the multilinear extension of its value across all instances, represented on an n-dimensional hypercube . More explicitly,
$$g\big( w_1(r_1, r_2, \dots, r_n), w_2(r_1, r_2, \dots, r_n), \dots, w_m(r_1, r_2, \dots, r_n)\big) = y$$ $\ w_1, \dots, w_m$ are the input wires to $\ w$ 's gate, $\ g$ .
where
The prover sends explicit claimed values$\ y_i = w_i(r_1, r_2, \dots, r_n) $ . The verifier checks if the consistency of these claims with the original claim about $\ w $ , i.e. whether indeed $\ g(y_1, y_2, \dots, y_m) = y$ and records the new claims to be verified later. In a non-interactive settings, $\ y_1, y_2, \dots, y_m$ are hashed, as new prover messages.
This optimization is based on the observation that if, say, the first variable of$\ g$ is solvable according to the above definition, the claim $\ y_1$ will not need to be hashed.
For a circuit consisting of 56K Poseidon2 permutations (equivalent to the Linea blob decompression circuit) this saves about 25K constraints, only about 0.5% of total constraints.