Fix logic mismatch in newR1C
for better Groth16 optimization
#1482
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the comment suggested that the goal was to minimize the number of variables in the B matrix, but the implementation did the opposite — swapping
L
andR
whenL
was longer. This PR corrects the condition to match the intended optimization logic, aligning with Groth16 performance best practices.Fixes # (no issue number yet)
Type of change
How has this been tested?