Skip to content

Feat/eip4844 precompile #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

ThomasPiellard
Copy link
Collaborator

Description

Implementation of the EIP4844 precompile.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

See marshall_test.go, kzg_point_evaluation_test.go

How has this been benchmarked?

Unmarshall #constraints: 1772 when compiled on BN254, emulating BLS12-381 base field
UnmarshalCompressed #constraints: 585600 when compiled on BN254, emulating BLS12-381 base field
KzgPointEvaluation #constraints: 3772424 when compiled on BN254, emulating BLS12-381 base field

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasPiellard ThomasPiellard requested a review from ivokub May 5, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants