feat: allow taking benchmarking instance in NewAssert #1607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometimes when trying to benchmark some existing tests (i.e. compile time, proving time etc), I'd want to copy-paste current test and then run it. But as
test.Assert
does not support taking*testing.B
as input then I had to rewrite a lot.This PR makes it take either and then switch the implementation. Benchmarking with
Assert.CheckCircuit
doesn't make much sense as it reuses compiled circuits, but I added a comment to indicate that. And we usually benchmark only a very specific part.Type of change
Checklist:
golangci-lint
does not output errors locally