Skip to content

Conversation

stemlaud
Copy link

@stemlaud stemlaud commented Sep 25, 2025

Description

Go 1.21 adds built-in functions min and max. https://tip.golang.org/doc/go1.21
Therefore, we can directly remove our own implementations and use the built-in function with the same names.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

  • Test A
  • Test B

How has this been benchmarked?

  • Benchmark A, on Macbook pro M1, 32GB RAM
  • Benchmark B, on x86 Intel xxx, 16GB RAM

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub added feat: gkr PRs related to GKR src: community Community originating PRs and issues labels Sep 25, 2025
@stemlaud
Copy link
Author

@ivokub Hi, Could you please review this PR at your convenience? Thank you very much.

@ivokub
Copy link
Collaborator

ivokub commented Oct 13, 2025

@ivokub Hi, Could you please review this PR at your convenience? Thank you very much.

Thanks for the contribution. Seems to be a small change. We will merge small community PRs into a single commit to be merged to gnark master before next release to simplify review, CI and development workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: gkr PRs related to GKR src: community Community originating PRs and issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants