Skip to content

Conversation

viktorking7
Copy link

@viktorking7 viktorking7 commented Sep 29, 2025

Description

  • Summary: Replace a shadowed assignment that prevented creating a zero polynomial when n == -1.
  • Problem: In getRandomPolynomial, a was redeclared with a := under n == -1, leaving the outer slice nil and failing to cancel blinding as intended.
  • Fix: Change a := make(... to a = make(... so the outer variable is set.
  • Impact: Ensures correct “cancel the blinding” behavior.

Note

Fixes a shadowed variable so getRandomPolynomial(-1) returns a zero polynomial, correctly canceling blinding.

  • PLONK bn254 backend:
    • In backend/plonk/bn254/prove.go, update getRandomPolynomial to assign to existing a instead of redeclaring (a = make(...)), ensuring n == -1 produces a zero polynomial to cancel blinding.

Written by Cursor Bugbot for commit a3d3149. This will update automatically on new commits. Configure here.

@ivokub ivokub added type: typo Fixes typos in comments or documentation src: community Community originating PRs and issues labels Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

src: community Community originating PRs and issues type: typo Fixes typos in comments or documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants