Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions std/hash/hash.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package hash

import (
"github.com/consensys/gnark/frontend"
"github.com/consensys/gnark/std/lookup/logderivlookup"
"github.com/consensys/gnark/std/math/uints"
)

Expand Down Expand Up @@ -112,8 +113,11 @@ type merkleDamgardHasher struct {
api frontend.API
}

// NewMerkleDamgardHasher transforms a 2-1 one-way function into a hash
// initialState is a value whose preimage is not known
// NewMerkleDamgardHasher range-extends a 2-1 one-way hash compression function into a hash by way of the Merkle-Damgård construction.
// Parameters:
// - api: constraint builder
// - f: 2-1 hash compression (one-way) function
// - initialState: the initialization vector (IV) in the Merkle-Damgård chain. It must be a value whose preimage is not known.
func NewMerkleDamgardHasher(api frontend.API, f Compressor, initialState frontend.Variable) FieldHasher {
return &merkleDamgardHasher{
state: initialState,
Expand All @@ -136,3 +140,24 @@ func (h *merkleDamgardHasher) Write(data ...frontend.Variable) {
func (h *merkleDamgardHasher) Sum() frontend.Variable {
return h.state
}

// SumMerkleDamgardDynamicLength computes the Merkle-Damgård hash of the input data, truncated at the given length.
// Parameters:
// - api: constraint builder
// - f: 2-1 hash compression (one-way) function
// - initialState: the initialization vector (IV) in the Merkle-Damgård chain. It must be a value whose preimage is not known.
// - length: length of the prefix of data to be hashed. The verifier will not accept a value outside the range {0, 1, ..., len(data)}.
// The gnark prover will refuse to attempt to generate such an unsuccessful proof.
// - data: the values a prefix of which is to be hashed.
func SumMerkleDamgardDynamicLength(api frontend.API, f Compressor, initialState frontend.Variable, length frontend.Variable, data []frontend.Variable) frontend.Variable {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this function signature allow for length extension attacks? I.e. lets say:

  • IV = 0
  • f_0 = compress(IV, msg_0)
  • f_1 = compress(f_0, msg_1)

Then, when we do either:
SumMerkleDamgardDynamicLength(api, Compressor, IV, 2, [msg_0, msg_1])
or
SumMerkleDamgardDynamicLength(api, Compressor, f_0, 1, [msg_1, msg_xxx])
we would get the same result? And considering all are user inputs then it could imo lead to possible collisions.

We also provide variable-length mode for binary hashes (see interface BinaryFixedLengthHasher). But there depending on the underlying hash function (sha256, ripemd, sha3) the length is appended to the input, avoid collision problems.

resT := logderivlookup.New(api)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And imo this method diverges from the rest of the APIs we use for hashers - otherwise we have defined FieldHasher for algebraic hash, and BinaryHasher/BinaryFixedLengthHasher for binary hashes (the ..FixedLengthHasher providing the same functionality i.e. allowing to dynamically set the input length to be hash).

I recommend following similar patter for consistency -- create FieldFixedLengthHasher interface

type FieldFixedLengthHasher interface {
    FieldHasher

    FixedLengthSum(length frontend.Variable) frontend.Variable
}

and then make in MiMC and Poseidon2 packages return this instead of FieldHasher.

state := initialState

resT.Insert(state)
for _, v := range data {
state = f.Compress(state, v)
resT.Insert(state)
}

return resT.Lookup(length)[0]
}
43 changes: 35 additions & 8 deletions std/hash/poseidon2/poseidon2_test.go
Original file line number Diff line number Diff line change
@@ -1,41 +1,68 @@
package poseidon2

import (
"fmt"
"testing"

"github.com/consensys/gnark-crypto/ecc"
"github.com/consensys/gnark-crypto/ecc/bls12-377/fr/poseidon2"
"github.com/consensys/gnark-crypto/ecc/bls12-377/fr"
gcPoseidon2 "github.com/consensys/gnark-crypto/ecc/bls12-377/fr/poseidon2"
"github.com/consensys/gnark/frontend"
"github.com/consensys/gnark/std/hash"
"github.com/consensys/gnark/std/permutation/poseidon2"
"github.com/consensys/gnark/test"
)

type Poseidon2Circuit struct {
Input []frontend.Variable
Expected frontend.Variable `gnark:",public"`
Expected []frontend.Variable `gnark:",public"` // Expected[i] = H(Input[:i+1])
}

func (c *Poseidon2Circuit) Define(api frontend.API) error {
if len(c.Input) != len(c.Expected) {
return fmt.Errorf("length mismatch")
}
hsh, err := NewMerkleDamgardHasher(api)
if err != nil {
return err
}
hsh.Write(c.Input...)
api.AssertIsEqual(hsh.Sum(), c.Expected)

compressor, err := poseidon2.NewPoseidon2(api)
if err != nil {
return err
}

for i := range c.Input {
hsh.Write(c.Input[i])
api.AssertIsEqual(c.Expected[i], hsh.Sum())
api.AssertIsEqual(c.Expected[i], hash.SumMerkleDamgardDynamicLength(api, compressor, 0, i+1, c.Input))
}

return nil
}

func TestPoseidon2Hash(t *testing.T) {
assert := test.NewAssert(t)

var buf [fr.Bytes]byte
const nbInputs = 5
// prepare expected output
h := poseidon2.NewMerkleDamgardHasher()
h := gcPoseidon2.NewMerkleDamgardHasher()
expected := make([]frontend.Variable, nbInputs)
circInput := make([]frontend.Variable, nbInputs)
for i := range nbInputs {
_, err := h.Write([]byte{byte(i)})
buf[fr.Bytes-1] = byte(i)
_, err := h.Write(buf[:])
assert.NoError(err)
circInput[i] = i
expected[i] = h.Sum(nil)
}
res := h.Sum(nil)
assert.CheckCircuit(&Poseidon2Circuit{Input: make([]frontend.Variable, nbInputs)}, test.WithValidAssignment(&Poseidon2Circuit{Input: circInput, Expected: res}), test.WithCurves(ecc.BLS12_377)) // we have parametrized currently only for BLS12-377
assert.CheckCircuit(
&Poseidon2Circuit{
Input: make([]frontend.Variable, nbInputs),
Expected: make([]frontend.Variable, nbInputs),
}, test.WithValidAssignment(&Poseidon2Circuit{
Input: circInput,
Expected: expected,
}), test.WithCurves(ecc.BLS12_377)) // we have parametrized currently only for BLS12-377
}
Loading