Eip 2537 precompile for bls12 381 curve operations #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,11 @@ | |||
| (module bls) | |||
|
|
|||
| (defconstraint id-increment () | |||
There was a problem hiding this comment.
Why we don't do like with other modules and just call WCP to check the id increment ?
There was a problem hiding this comment.
We used this same approach in ecdata, too. Is there any advantage in doing this with wcp lookups?
There was a problem hiding this comment.
simplicity, we do like this with SHAKIRA, BLAKEMODEXP, less columns, we had a failing edgecase with the manual byte decomposition with EcDAta on mainnet few months ago
There was a problem hiding this comment.
we even have a spec issue to delete it from EcData : https://github.com/Consensys/linea-specification-internal/issues/482
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.