fix: env variables in gihub action

Consensys · Apr 19, 2024 · 2d25b2d · 2d25b2d
1 parent 760bb6b
commit 2d25b2d
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/.github/workflows/ens-app-build-publish.yml b/.github/workflows/ens-app-build-publish.yml
@@ -42,16 +42,16 @@ jobs:
         uses: docker/setup-buildx-action@v2
 
       - name: Docker Image Build and Publish
-        env:
-          NEXT_PUBLIC_INFURA_KEY: ${{ secrets.NEXT_PUBLIC_INFURA_KEY }}
-          NEXT_PUBLIC_BASE_DOMAIN: ${{ secrets.NEXT_PUBLIC_BASE_DOMAIN }}
-          NEXT_PUBLIC_ALCHEMY_KEY: ${{ secrets.NEXT_PUBLIC_ALCHEMY_KEY }}
-          NEXT_PUBLIC_POH_SIGNATURE_API: "https://poh-verifier.dev.linea.build"
         if: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/') }}
         uses: docker/build-push-action@v4
         with:
           context: ./
           file: ./packages/ens-app-v3/Dockerfile
           push: true
           tags: consensys/linea-resolver:${{ env.DOCKER_TAG }}
-          build-args: BUILD_COMMAND="pnpm build"
+          build-args: |
+            NEXT_PUBLIC_INFURA_KEY=${{ secrets.NEXT_PUBLIC_INFURA_KEY }}
+            NEXT_PUBLIC_BASE_DOMAIN=${{ secrets.NEXT_PUBLIC_BASE_DOMAIN }}
+            NEXT_PUBLIC_ALCHEMY_KEY=${{ secrets.NEXT_PUBLIC_ALCHEMY_KEY }}
+            NEXT_PUBLIC_POH_SIGNATURE_API="https://poh-verifier.dev.linea.build"
+            BUILD_COMMAND="pnpm build"
diff --git a/packages/ens-app-v3/Dockerfile b/packages/ens-app-v3/Dockerfile
@@ -12,6 +12,15 @@ RUN apt-get update && apt-get install -y \
 
 WORKDIR /app
 
+ARG NEXT_PUBLIC_BASE_DOMAIN
+ARG NEXT_PUBLIC_ALCHEMY_KEY
+ARG NEXT_PUBLIC_INFURA_KEY
+ARG NEXT_PUBLIC_POH_SIGNATURE_API
+ENV NEXT_PUBLIC_BASE_DOMAIN=$NEXT_PUBLIC_BASE_DOMAIN
+ENV NEXT_PUBLIC_ALCHEMY_KEY=$NEXT_PUBLIC_ALCHEMY_KEY
+ENV NEXT_PUBLIC_INFURA_KEY=$NEXT_PUBLIC_INFURA_KEY
+ENV NEXT_PUBLIC_POH_SIGNATURE_API=$NEXT_PUBLIC_POH_SIGNATURE_API
+
 COPY . .
 
 # Install pnpm and dependencies