Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use web3signer secrets instead of private key to build poh-signer-api #189

Merged
merged 1 commit into from
Jul 9, 2024
Merged

feat: use web3signer secrets instead of private key to build poh-signer-api #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/poh-signer-api-build-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ jobs:
with:
build-args: |
ENV_FILE=.env.testnet
SIGNER_PRIVATE_KEY=${{ secrets.POH_VERIFIER_TESTNET_PRIVATE_KEY }}
WEB3SIGNER_BASE_URL=${{ secrets.WEB3SIGNER_BASE_URL_TESTNET }}
WEB3SIGNER_PUBLIC_KEY=${{ secrets.WEB3SIGNER_PUBLIC_KEY_TESTNET }}
context: ./packages/poh-signer-api
file: ./packages/poh-signer-api/Dockerfile
push: true
Expand All @@ -67,7 +68,8 @@ jobs:
with:
build-args: |
ENV_FILE=.env.mainnet
SIGNER_PRIVATE_KEY=${{ secrets.POH_VERIFIER_MAINNET_PRIVATE_KEY }}
WEB3SIGNER_BASE_URL=${{ secrets.WEB3SIGNER_BASE_URL_MAINNET }}
WEB3SIGNER_PUBLIC_KEY=${{ secrets.WEB3SIGNER_PUBLIC_KEY_MAINNET }}
context: ./packages/poh-signer-api
file: ./packages/poh-signer-api/Dockerfile
push: true
Expand Down
4 changes: 2 additions & 2 deletions packages/poh-signer-api/.env.mainnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ POH_API_URL=https://linea-xp-poh-api.linea.build
CHAIN_ID=59144

# Web3Signer
WEB3SIGNER_BASE_URL=http://localhost:9000
WEB3SIGNER_PUBLIC_KEY=0x9d2a12cf4ff79398f8f930fed1b772dea9917aa62360067b6463af5f40a2182d26740cbeb5c8ea966e710d111be353dfb284b9b20b16406adfd94f7855fd22a1
WEB3SIGNER_BASE_URL=
WEB3SIGNER_PUBLIC_KEY=
4 changes: 2 additions & 2 deletions packages/poh-signer-api/.env.testnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ POH_API_URL=https://linea-xp-poh-api.linea.build
CHAIN_ID=59141

# Web3Signer
WEB3SIGNER_BASE_URL=http://localhost:9000
WEB3SIGNER_PUBLIC_KEY=0x9d2a12cf4ff79398f8f930fed1b772dea9917aa62360067b6463af5f40a2182d26740cbeb5c8ea966e710d111be353dfb284b9b20b16406adfd94f7855fd22a1
WEB3SIGNER_BASE_URL=
WEB3SIGNER_PUBLIC_KEY=
6 changes: 4 additions & 2 deletions packages/poh-signer-api/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,11 @@ FROM node:18
WORKDIR /app

ARG ENV_FILE
ARG SIGNER_PRIVATE_KEY
ARG WEB3SIGNER_BASE_URL
ARG WEB3SIGNER_PUBLIC_KEY

ENV SIGNER_PRIVATE_KEY=$SIGNER_PRIVATE_KEY
ENV WEB3SIGNER_BASE_URL=$WEB3SIGNER_BASE_URL
ENV WEB3SIGNER_PUBLIC_KEY=$WEB3SIGNER_PUBLIC_KEY

COPY . .

Expand Down
Loading