-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linea_sendBundle #135
linea_sendBundle #135
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very promising, I added a couple of comments and will adjust the API accordingly
private int calculateWeight(TransactionBundle bundle) { | ||
return bundle.pendingTransactions.stream() | ||
.mapToInt(pt -> pt.getTransaction().getPayload().size()) | ||
.sum(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PendingTransaction
has a better way to compute the estimated memory size
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used Transaction:getSize for now, since the PendingTransaction interface doesn't export memorySize()
.../net/consensys/linea/sequencer/txselection/selectors/LineaSendBundleTransactionSelector.java
Outdated
Show resolved
Hide resolved
6347c4f
to
67bfbe1
Compare
outstanding work on creating a shared singleton bundle pool before we can smoke test the endpoint. Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
b28c5a9
to
3e47c80
Compare
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
Signed-off-by: garyschulte <[email protected]>
…ization issues Signed-off-by: garyschulte <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
…h_sendBundle-merge # Conflicts: # sequencer/src/main/java/net/consensys/linea/sequencer/txselection/LineaTransactionSelectorFactory.java # sequencer/src/main/java/net/consensys/linea/sequencer/txselection/selectors/LineaTransactionSelector.java
sequencer/build.gradle
Outdated
implementation 'com.google.code.gson:gson' | ||
implementation 'com.github.ben-manes.caffeine:caffeine:3.1.8' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to specify the version since we inherit it from the Besu BOM
implementation 'com.google.code.gson:gson' | |
implementation 'com.github.ben-manes.caffeine:caffeine:3.1.8' | |
implementation 'com.github.ben-manes.caffeine:caffeine' | |
implementation 'com.google.code.gson:gson' |
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
also to simplify assume that the bundle pool is always available. Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
a64b5f3
to
e33c025
Compare
Eth send bundle merge
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
…h_sendBundle-merge
Signed-off-by: Fabio Di Fabio <[email protected]>
Signed-off-by: Fabio Di Fabio <[email protected]>
ERC20 bundle AT
Signed-off-by: Fabio Di Fabio <[email protected]>
…h_sendBundle-merge
Eth send bundle merge
replaced by #142 |
plugin for linea_sendBundle, endpoints:
linea_sendBundle implements eth_sendBundle interface
linea_cancelBundle implements eth_cancelBundle interface
Notably linea_sendBundle does not implement any behavior for
builders
. Otherwise feature complete, but PR is in draft state awaiting upstream plugin-api changes in linea-besu that support this endpoint.example usages:
linea_sendBundle:
linea_cancelBundle: