OOB: add constraint to disallow the BLS precompiles from EIP-2537: Precompile for BLS12-381 curve operations use in Cancun #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBBB
reviewed
Jun 4, 2025
There was a problem hiding this comment.
I would suggest the following change
- create two new shorthands
\locFlagSumEipBlobTransactionswhich is just POINT_EVALUATION\locFlagSumEipBlsTwelvePrecompileswhich is the sum of the other BLS precompile flags
- make
locPrcFlagSumBlsbe the sum of these two - replace the vanishing condition with
If the Ethereum network configuration is at the Cancun hard fork, one may further impose
$\ locFlagSumEipBlsTwelvePrecompiles _{i} = 0$
The reason for this request is that POINTEVALUATION is itself BLS related, so the condition is confusing. One may alternatively use shorthands à la
\locFlagSumNewCancunPrecompiles
\locFlagSumNewPraguePrecompiles
OlivierBBB
requested changes
Jun 10, 2025
| \locFlagSumEipBlobTransactions_{i} & \define & | ||
| \left[ \begin{array}{cl} | ||
| + & \oobInstIsPointEvaluation_{i} \\ | ||
| \end{array} \right] \vspace{2mm} \\ |
There was a problem hiding this comment.
Here you can remove the array (as we aren't summing anything, it's just one term.)
| \maxCtFlagSumPrcBls_{i} & \define & | ||
| \left[ \begin{array}{cl} | ||
| + & \maxCtFlagSumPrcEipBlobTransactions_ {i} \\ | ||
| + & \maxCtFlagSumPrcEipBlsTwelvePrecompiles_ {i} \\ |
There was a problem hiding this comment.
It should be
\macroName _{i}| \weightedPrcEipBlobTransactions_{i} & \define & | ||
| \left[ \begin{array}{crcl} | ||
| + & \oobInstPointEvaluation & \cdot & \oobInstIsPointEvaluation _{i} \\ | ||
| \end{array} \right] \vspace{2mm} \\ |
There was a problem hiding this comment.
Similarly here, no need for an array as it's a single term.
| \left[ \begin{array}{crcl} | ||
| + & \oobCtMaxPointEvaluation & \cdot & \oobInstIsPointEvaluation _{i} \\ | ||
| \end{array} \right] \vspace{2mm} \\ | ||
| \maxCtFlagSumPrcEipBlsTwelvePrecompiles_{i} & \define & |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.