feat: account event change get starknet #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanti42
force-pushed
the
feat/switch-account-ui
branch
from
7f2080a to
b5dd6c4
Compare
…urrent-account-from-state
khanti42
force-pushed
the
feat/account-event-change-get-starknet
branch
from
6c2fa0b to
c2ff296
Compare
stanleyyconsensys
requested changes
Jan 17, 2025
|
i see that the on / off is never tested in unit test, may be we should add it back, else we can forget forever |
Base automatically changed from
feat/switch-account-ui
to
feat/enable-multiple-accounts
January 17, 2025 12:12
stanleyyconsensys
approved these changes
Jan 22, 2025
|
|
stanleyyconsensys
merged commit a6acd86
into
feat/enable-multiple-accounts
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-01-16.at.10.52.07.mov