-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8424 use attestations v2 #8457
Closed
mehdi-aouadi
wants to merge
15
commits into
Consensys:master
from
mehdi-aouadi:8424-use-attestations-v2
Closed
8424 use attestations v2 #8457
mehdi-aouadi
wants to merge
15
commits into
Consensys:master
from
mehdi-aouadi:8424-use-attestations-v2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
mehdi-aouadi
force-pushed
the
8424-use-attestations-v2
branch
from
July 19, 2024 16:23
04b498a
to
d04d76f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Added
sendSignedAttestationsV2
method inbeacon/validator/src/main/java/tech/pegasys/teku/validator/coordinator/ValidatorApiHandler.java
- Introduced
PostAttestationsV2IntegrationTest.java
for integration tests indata/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v2/beacon
- Added new endpoint
/eth/v2/beacon/pool/attestations
indata/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/PostAttestationsV2.java
- Updated
ValidatorDataProvider.java
to includesubmitAttestationsV2
method indata/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java
- Introduced new hidden CLI option
--Xattestations-v2-enabled
inteku/src/main/java/tech/pegasys/teku/cli/options/ValidatorOptions.java
29 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Outdated, will raise a new PR onces the APIs are merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Rebased on top of #8448
Add a hidden option
--Xattestations-v2-enabled
to enable the newPostAttestationsV2
APIFixed Issue(s)
#8424
Documentation
doc-change-required
label to this PR if updates are required.Changelog