Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8424 use attestations v2 #8457

Closed

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Jul 19, 2024

PR Description

Rebased on top of #8448
Add a hidden option --Xattestations-v2-enabled to enable the new PostAttestationsV2 API

Fixed Issue(s)

#8424

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi self-assigned this Jul 19, 2024
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

  • Added sendSignedAttestationsV2 method in beacon/validator/src/main/java/tech/pegasys/teku/validator/coordinator/ValidatorApiHandler.java
  • Introduced PostAttestationsV2IntegrationTest.java for integration tests in data/beaconrestapi/src/integration-test/java/tech/pegasys/teku/beaconrestapi/v2/beacon
  • Added new endpoint /eth/v2/beacon/pool/attestations in data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/PostAttestationsV2.java
  • Updated ValidatorDataProvider.java to include submitAttestationsV2 method in data/provider/src/main/java/tech/pegasys/teku/api/ValidatorDataProvider.java
  • Introduced new hidden CLI option --Xattestations-v2-enabled in teku/src/main/java/tech/pegasys/teku/cli/options/ValidatorOptions.java

29 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@mehdi-aouadi mehdi-aouadi marked this pull request as draft August 16, 2024 13:41
@mehdi-aouadi
Copy link
Contributor Author

Outdated, will raise a new PR onces the APIs are merged

@mehdi-aouadi mehdi-aouadi deleted the 8424-use-attestations-v2 branch August 21, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants