Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROTOTYPE] epbs-eip7732 #8497

Closed
wants to merge 30 commits into from
Closed

[PROTOTYPE] epbs-eip7732 #8497

wants to merge 30 commits into from

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Aug 2, 2024

https://github.com/ethereum/consensus-specs/tree/dev/specs/_features/eip7732

Search for EIP7332 TODO in Files changed to see the items which need fixing.

fixes #8545

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

.forEach(
idx -> {
final IntList beaconCommittee = getBeaconCommittee(state, slot, idx);
for (int i = 0; i < Math.min(membersPerCommittee, beaconCommittee.size()); i++) {

Check failure

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition High test

Comparison between
expression
of type int and
expression
of wider type long.
@rolfyone
Copy link
Contributor

may be easier to run this as a full feature branch.. just a thought...

syncCommitteeMessageOperationProcessor,
final OperationProcessor<SignedBlsToExecutionChange>
signedBlsToExecutionChangeOperationProcessor,
final OperationProcessor<SignedExecutionPayloadEnvelope> executionPayloadProcessor,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'executionPayloadProcessor' is never used.
final OperationProcessor<SignedBlsToExecutionChange>
signedBlsToExecutionChangeOperationProcessor,
final OperationProcessor<SignedExecutionPayloadEnvelope> executionPayloadProcessor,
final OperationProcessor<PayloadAttestation> payloadAttestationProcessor,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'payloadAttestationProcessor' is never used.
signedBlsToExecutionChangeOperationProcessor,
final OperationProcessor<SignedExecutionPayloadEnvelope> executionPayloadProcessor,
final OperationProcessor<PayloadAttestation> payloadAttestationProcessor,
final OperationProcessor<SignedExecutionPayloadHeader> executionPayloadHeaderProcessor,

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'executionPayloadHeaderProcessor' is never used.
@mehdi-aouadi mehdi-aouadi changed the base branch from master to epbs September 4, 2024 09:21
@mehdi-aouadi mehdi-aouadi changed the base branch from epbs to master September 4, 2024 11:46
@StefanBratanov
Copy link
Contributor

Closing this one in favour of the https://github.com/Consensys/teku/tree/epbs branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prototype on EIP-7732 (ePBS)
4 participants